Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace direct version string comparison with packaging.version.parse() #1863

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace direct version string comparison with packaging.version.parse() #1863

wants to merge 2 commits into from
+7 −3

Conversation

rschutski
Copy link

Motivation

Current direct version comparison fails with torchtext < 0.10.0

Modification

Replaced direct version string comparisons with packaging.version.parse()

BC-breaking (Optional)

No

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@rschutski
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@rschutski
Copy link
Author

recheck

github-actions bot added a commit that referenced this pull request Mar 6, 2025
@github-actions
@rschutski has signed the CLA in #1863
9c295af
@qbit-
Copy link

qbit- commented Mar 7, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 7, 2025
@github-actions
@qbit- has signed the CLA in #1863
01637d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rschutski @qbit-